[jetbrains_projects] Fix Rider config#207
[jetbrains_projects] Fix Rider config#207ManuelSchneid3r merged 1 commit intoalbertlauncher:mainfrom
Conversation
tomsquest
left a comment
There was a problem hiding this comment.
Ah Jetbrains... :/
I would have skipped is_rider and detect it inline in the Editor class, but LGTM.
|
Is there anything blocking this PR from being merged? |
|
At least the fact that api is not compatible. But that's a minor issue. Generally I think there is room for improvement here, but I am busy with core things and actually it works. So for me it is low priority. |
|
What do you mean by "API not compatible"? Should I remove the |
https://github.com/albertlauncher/plugins/blob/main/python/albert.pyi 0.27 came with a python api update |
|
Ah wait. I clicked view file above and saw the old file. But probably the merge only merges the changes not the entire file. |
Fixes albertlauncher/albert#1473