Conversation
|
Hi, please avoid formatting codes you don't touch. If you want to format the code, a new PR is welcome. |
|
Oh right, my bad, I'm too used to have my auto formatter always on, this should be reverted! |
|
I have a concern that the current user doesn't have the codes to handle the result of Can we simply add an optional parameter to the What's your opinion on this? |
I like the idea. I wanted to avoid affecting the signature as much as possible, but I think a default option serves this role perfectly |
|
Except for the minor review comment, this change looks good to me. However, an update for the |
As mentioned in #90, it would be useful for me to be able to quit before making the choice. This is my proposition on how to do it