Open
Conversation
- Adds the option to add separators within the `${...}` variables.
- More ambitious goal I have in mind would be to support conditionals.
Contributor
Author
|
Note, this PR was just doing some cleanup. This stuff was like copy-pasted in all different MergeProcesses. // Read content and inject any config parameters
var infoAdditionsProjectContent:String = FileUtils.readFileContentAsString( infoAdditionsProjectFile );
for (var name:String in APM.config.projectDefinition.configuration)
{
var regex:RegExp = new RegExp( "\\$\\{" + name + "\\}", "g" );
var value:String = APM.config.projectDefinition.getConfigurationParam( name );
infoAdditionsProjectContent = infoAdditionsProjectContent.replace( regex, value );
}
infoAdditionsProjectContent = infoAdditionsProjectContent.replace( /\$\{applicationId\}/g, APM.config.projectDefinition.applicationId );
FileUtils.writeStringAsFileContent( infoAdditionsFile, infoAdditionsProjectContent );This change was to have all that code in a single place, a helper class that implements the config-file templating engine. Now there are some conflicts, but I'll solve them if you agree it's a valid change. |
Contributor
|
I think our main concern with this one was just the naming of the class |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
${...}variables.