Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
document.py,package.py)을 우선 보강하여 신뢰성을 높이고자 했습니다.Description
pyproject.toml의testextra에pytest-cov>=5.0을 추가하여 커버리지 플러그인을 설치하도록 했습니다 (pyproject.toml)..github/workflows/tests.yml)의 테스트 실행을pytest -v -ra --cov=hwpx --cov-report=term-missing --cov-fail-under=${COVERAGE_FAIL_UNDER}로 변경하고, 환경변수COVERAGE_FAIL_UNDER: 50로 단계적 도입 계획(50 -> 60 -> 70)을 주석으로 명시했습니다.tests/test_coverage_targets.py를 추가하여_append_element,HwpxDocument._flush_resource/_close_resource동작과hwpx.package모듈의 deprecation 경고 및__all__내보내기 심볼을 검증하도록 했습니다.src/hwpx/oxml/document.py에서 lxml/xml.etree 타입 혼합으로 발생하던 오류를 해결하기 위해 부모 요소 타입에 맞춰makeelement/append경로로 정리하고, 필요한 경우xml.etree.ElementTree생성 요소를lxml.etree로 변환하여 append 하도록 보완했습니다.Testing
pip install -e '.[test,typecheck]'이 성공적으로 실행되었습니다.pytest --cov=hwpx --cov-report=term-missing --cov-fail-under=50을 실행하여74 passed, 4 skipped를 확인했고 전체 커버리지는 약80%로 설정한 기준(50%)을 충족했습니다.tests/test_tables_default_border.py, 새로 추가한 대상 테스트들)가 통과함을 확인했습니다.Codex Task