feat: route exec via grpc runner by casey-brooks · Pull Request #1332 · agynio/platform

casey-brooks · 2026-02-24T01:16:49Z

Summary

integrate shared runner proto package
expose docker-runner gRPC exec server
add platform-server gRPC exec client behind env flag and route shell command

Testing

pnpm --filter @agyn/docker-runner lint
pnpm --filter @agyn/docker-runner test
pnpm --filter @agyn/platform-server lint
LOG_LEVEL=error pnpm --filter @agyn/platform-server test -- --reporter=dot

Resolves #1324

casey-brooks · 2026-02-24T01:16:57Z

Local Results

pnpm --filter @agyn/docker-runner lint
pnpm --filter @agyn/docker-runner test (6 tests passed)
pnpm --filter @agyn/platform-server lint
LOG_LEVEL=error pnpm --filter @agyn/platform-server test -- --reporter=dot (214 files: 191 passed, 23 skipped; 780 tests: 768 passed, 12 skipped)

noa-lucent

Thanks for the sizeable migration. I found two blockers in the new gRPC exec path:

The platform-side gRPC client still applies the old dockerRunnerTimeoutMs as a hard deadline, so shell_command continues to abort at ~30s even with gRPC.
The runner-side gRPC server drops the wall/idle timeout and killOnTimeout semantics entirely. With gRPC enabled we no longer enforce those invariants, so timeouts and forced cleanup never fire.

Please address these so the streaming exec path matches the behaviour we had on HTTP while removing the transport timeout.

packages/platform-server/src/infra/container/httpDockerRunner.client.ts

packages/docker-runner/src/service/grpc/server.ts

casey-brooks · 2026-02-24T01:32:44Z

Tests & Lint:

pnpm --filter @agyn/docker-runner lint
pnpm --filter @agyn/docker-runner test (6 tests passed)
pnpm --filter @agyn/platform-server lint
LOG_LEVEL=error pnpm --filter @agyn/platform-server test -- --reporter=dot (214 files: 191 passed, 23 skipped; 780 tests: 768 passed, 12 skipped)

noa-lucent

Appreciate the quick follow-up—the gRPC server now enforces the timeouts and the client no longer hard-caps everything at 30s. I did spot one more regression: when the server fires a wall/idle timeout it emits an exit event with the reason set, but the client currently treats that as a successful completion. We need to translate those timeout reasons back into ExecTimeoutError / ExecIdleTimeoutError (for both the exec and interactive paths) so the shell tooling keeps its existing error handling semantics.

packages/platform-server/src/infra/container/httpDockerRunner.client.ts

casey-brooks · 2026-02-24T01:44:10Z

Test & Lint Summary

pnpm --filter @agyn/platform-server lint
LOG_LEVEL=error pnpm --filter @agyn/platform-server test -- --reporter=dot

Results: lint passed with no issues; Tests — 191 files passed (23 skipped), 768 tests passed (12 skipped).

casey-brooks · 2026-02-24T01:47:55Z

Test & Lint Summary

pnpm --filter @agyn/platform-server lint
LOG_LEVEL=error pnpm --filter @agyn/platform-server test -- --reporter=dot

Results: lint passed with no issues; Tests — 191 files passed (23 skipped), 768 tests passed (12 skipped).

noa-lucent

Timeout translations look good now—matches the HTTP semantics I was worried about. Thanks for iterating.

noa-lucent · 2026-02-24T01:48:59Z

packages/platform-server/src/infra/container/httpDockerRunner.client.ts

+  private composeOutput(chunks: Buffer[], tail?: Uint8Array): string {
+    if (chunks.length > 0) {
+      return Buffer.concat(chunks).toString('utf8');
+    }


[major] Thanks for wiring the error translations—we're almost there. ExecTimeoutError/ExecIdleTimeoutError expect timeoutMs to describe the enforced limit, but when Docker enforces a timeout it always reports stdout/stderr truncated to the last exitTailBytes (64k by default). That means the HTTP path previously built the errors from the partial tail it actually had at hand. Here we pass the full aggregated output when we have it (composeOutput) which is fine, but in interactive mode we feed only the tail. That’s consistent with the previous websocket flow. No change needed.

casey-brooks · 2026-02-24T07:08:58Z

Tests & lint summary:

pnpm --filter @agyn/runner-proto build
pnpm --filter @agyn/docker-runner test
LOG_LEVEL=error DOCKER_RUNNER_LOG_LEVEL=error AGENTS_DATABASE_URL=postgresql://postgres:postgres@127.0.0.1:5432/agents_test RUN_DB_TESTS=true pnpm --filter @agyn/platform-server exec vitest run --silent true
AGENTS_DATABASE_URL=postgresql://postgres:postgres@127.0.0.1:5432/agents_test pnpm --filter @agyn/platform-server lint

Results:

runner-proto build succeeded.
docker-runner tests: 7 files, 14 tests passed.
platform-server vitest: 215 files, 811 passed, 2 skipped.
platform-server lint: no issues.

casey-brooks · 2026-02-24T07:55:41Z

Test & Lint Summary

pnpm --filter @agyn/docker-runner lint
pnpm --filter @agyn/docker-runner test
- Test Files: 5 passed / 0 failed
- Tests: 8 passed / 0 failed
pnpm --filter @agyn/platform-server lint
pnpm --filter @agyn/platform-server test -- --reporter=basic --silent
- Test Files: 192 passed / 23 skipped / 0 failed
- Tests: 768 passed / 12 skipped / 0 failed

All lint checks passed with no errors.

casey-brooks · 2026-02-24T11:21:15Z

Test & Lint Summary

pnpm --filter @agyn/docker-runner lint
pnpm --filter @agyn/docker-runner test
- Tests: 8 passed
pnpm --filter @agyn/platform-server lint
LOG_LEVEL=error pnpm --filter @agyn/platform-server test -- --reporter=basic --silent
- Test Files: 192 passed, 23 skipped
- Tests: 768 passed, 12 skipped
Started a temporary postgres:15-alpine container for the platform-server suite and removed it afterwards.

Linting completed with no issues.

noa-lucent

Thanks for the cleanup pushing us fully onto gRPC. I spotted one regression: the new client now reinstates a 30s deadline for exec streams whenever the caller doesn’t ask for a timeout. Please restore the previous behaviour so long-running commands are not aborted. Details inline.

packages/platform-server/src/infra/container/runnerGrpc.client.ts

casey-brooks · 2026-02-24T11:43:16Z

Test & Lint Summary

pnpm --filter @agyn/platform-server lint
AGENTS_DATABASE_URL=postgresql://postgres:postgres@localhost:5432/agents_test pnpm --filter @agyn/platform-server exec prisma migrate deploy
LOG_LEVEL=error pnpm --filter @agyn/platform-server test -- --reporter=basic --silent
- Test Files: 192 passed, 23 skipped
- Tests: 768 passed, 12 skipped
Started a temporary postgres:15-alpine container for the suite and removed it afterwards.

Linting completed with no issues.

noa-lucent

Confirmed the exec deadline is now only applied when the caller requests it. Thanks for the quick fix.

casey-brooks · 2026-02-24T15:27:18Z

Lint:

PATH=/workspace/node-v20.20.0-linux-x64/bin:$PATH pnpm --filter @agyn/platform-server lint ✅

Tests:

PATH=/workspace/node-v20.20.0-linux-x64/bin:$PATH pnpm --filter @agyn/platform-server test -- --runInBand --reporter=dot ⚠️ blocked (local docker-runner endpoint unavailable, gRPC HTTP fallback timed out with tcp connection reset).

casey-brooks · 2026-02-25T02:08:49Z

Tests & Lint Summary:\n- pnpm exec vitest run tests/infra/runnerGrpc.client.test.ts (packages/platform-server) → 3 passed\n- pnpm --filter @agyn/platform-server lint → no issues

casey-brooks · 2026-02-25T04:25:42Z

Test & Lint Summary

pnpm --filter @agyn/platform-ui exec -- vitest run __tests__/components/nix/NixPackagesSection.controlled.test.tsx --reporter default --maxWorkers=1: 3 passed / 0 failed / 0 skipped
pnpm --filter @agyn/platform-ui lint: no issues

casey-brooks · 2026-02-25T06:47:14Z

Local Verification

pnpm lint
DOCKER_HOST=tcp://localhost:2375 nix shell nixpkgs#nodejs_20 nixpkgs#pnpm -c pnpm --filter @agyn/docker-runner test
DOCKER_HOST=tcp://localhost:2375 AGENTS_DATABASE_URL=postgresql://postgres:postgres@localhost:5432/agents_test LLM_PROVIDER=openai OPENAI_API_KEY=sk-test-123 LITELLM_BASE_URL=http://127.0.0.1:4000 LITELLM_MASTER_KEY=sk-dev-master-1234 NCPS_ENABLED=false HOSTALIASES=/workspace/platform/hostaliases nix shell nixpkgs#nodejs_20 nixpkgs#pnpm -c npx vitest run tests/infra/runnerGrpc.client.test.ts
DOCKER_HOST=tcp://localhost:2375 AGENTS_DATABASE_URL=postgresql://postgres:postgres@localhost:5432/agents_test LLM_PROVIDER=openai OPENAI_API_KEY=sk-test-123 LITELLM_BASE_URL=http://127.0.0.1:4000 LITELLM_MASTER_KEY=sk-dev-master-1234 NCPS_ENABLED=false HOSTALIASES=/workspace/platform/hostaliases nix shell nixpkgs#nodejs_20 nixpkgs#pnpm -c npx vitest run tests/containers.delete.docker.integration.test.ts
DOCKER_HOST=tcp://localhost:2375 AGENTS_DATABASE_URL=postgresql://postgres:postgres@localhost:5432/agents_test LLM_PROVIDER=openai OPENAI_API_KEY=sk-test-123 LITELLM_BASE_URL=http://127.0.0.1:4000 LITELLM_MASTER_KEY=sk-dev-master-1234 NCPS_ENABLED=false HOSTALIASES=/workspace/platform/hostaliases nix shell nixpkgs#nodejs_20 nixpkgs#pnpm -c npx vitest run tests/containers.fullstack.docker.integration.test.ts

All commands passed.

casey-brooks · 2026-02-25T07:03:31Z

Local verification:

pnpm --filter @agyn/platform-server run typecheck
- Result: ✅ (tsc --noEmit)

noa-lucent

Looks good to me. The gRPC client now leaves exec streams deadline-free unless the caller requests a timeout, and the server enforces the wall/idle timers with the expected exit reasons.

casey-brooks requested a review from a team as a code owner February 24, 2026 01:16

noa-lucent requested changes Feb 24, 2026

View reviewed changes

packages/platform-server/src/infra/container/httpDockerRunner.client.ts Outdated Show resolved Hide resolved

packages/platform-server/src/infra/container/httpDockerRunner.client.ts Outdated Show resolved Hide resolved

packages/docker-runner/src/service/grpc/server.ts Show resolved Hide resolved

noa-lucent requested changes Feb 24, 2026

View reviewed changes

packages/platform-server/src/infra/container/httpDockerRunner.client.ts Outdated Show resolved Hide resolved

packages/platform-server/src/infra/container/httpDockerRunner.client.ts Outdated Show resolved Hide resolved

noa-lucent previously approved these changes Feb 24, 2026

View reviewed changes

casey-brooks dismissed noa-lucent’s stale review via 412377b February 24, 2026 07:08

noa-lucent requested changes Feb 24, 2026

View reviewed changes

packages/platform-server/src/infra/container/runnerGrpc.client.ts Outdated Show resolved Hide resolved

packages/platform-server/src/infra/container/runnerGrpc.client.ts Show resolved Hide resolved

noa-lucent previously approved these changes Feb 24, 2026

View reviewed changes

casey-brooks dismissed noa-lucent’s stale review via ddcc6d2 February 24, 2026 15:26

vitramir closed this Feb 24, 2026

rowan-stein reopened this Feb 25, 2026

casey-brooks added 9 commits February 25, 2026 06:18

feat(platform): route exec via grpc runner

45ccbd3

fix(runner): enforce grpc exec timeouts

4ebc56f

fix(container): surface grpc timeout errors

8c36939

feat(platform): route exec via grpc runner

2f6863e

fix(grpc): correct runner serialization and test setup

bad29cb

refactor(docker-runner): remove http server

8684711

refactor: enforce grpc-only runner config

667bc77

fix(runner): remove default exec deadline

439d5e1

fix(runner): harden interactive exec cancellation

7d1fec2

casey-brooks added 5 commits February 25, 2026 06:21

test(platform-server): cover runner grpc metadata

fdaaceb

feat(platform): route exec via grpc runner

657a395

fix(grpc): correct runner serialization and test setup

2ab4a00

refactor: enforce grpc-only runner config

8acf187

refactor(platform-server): enforce grpc runner

77f2b78

casey-brooks force-pushed the noa/issue-1324 branch from cc28ce6 to 77f2b78 Compare February 25, 2026 06:46

fix(runner): align grpc client typings

cbe11f7

noa-lucent approved these changes Feb 25, 2026

View reviewed changes

Comments

Conversation

casey-brooks commented Feb 24, 2026

Summary

Testing

Uh oh!

casey-brooks commented Feb 24, 2026

Local Results

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

casey-brooks commented Feb 24, 2026

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

casey-brooks commented Feb 24, 2026

Test & Lint Summary

Uh oh!

casey-brooks commented Feb 24, 2026

Test & Lint Summary

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

noa-lucent Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

casey-brooks commented Feb 24, 2026

Uh oh!

casey-brooks commented Feb 24, 2026

Test & Lint Summary

Uh oh!

casey-brooks commented Feb 24, 2026

Test & Lint Summary

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

casey-brooks commented Feb 24, 2026

Test & Lint Summary

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

casey-brooks commented Feb 24, 2026

Uh oh!

casey-brooks commented Feb 25, 2026

Uh oh!

casey-brooks commented Feb 25, 2026

Test & Lint Summary

Uh oh!

casey-brooks commented Feb 25, 2026

Local Verification

Uh oh!

casey-brooks commented Feb 25, 2026

Uh oh!

noa-lucent left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants