Conversation
Contributor
Author
Summary
Testing
|
noa-lucent
requested changes
Feb 23, 2026
Contributor
noa-lucent
left a comment
There was a problem hiding this comment.
Summary:
- Reviewed UI changes for LLM context history action and empty state.
Required changes:
- Use an explicit context-delta status signal (per issue #1322) instead of inferring from /length for the empty state.
Contributor
Author
Summary
Testing
|
noa-lucent
previously approved these changes
Feb 23, 2026
Contributor
noa-lucent
left a comment
There was a problem hiding this comment.
Summary:
- Verified context delta status is now explicit and empty-state copy uses that signal.
- Tests updated to cover the new empty-state messaging and history action.
f7f52fb to
e638104
Compare
Contributor
Author
Summary
Testing
Notes
|
noa-lucent
requested changes
Feb 24, 2026
Contributor
noa-lucent
left a comment
There was a problem hiding this comment.
Summary:
- Reviewed new server LLM context pagination endpoint and UI refactor.
- Added comments on eager context prefetching and missing context-delta status wiring.
Changes requested:
- Avoid N+1 context fetches by lazy-loading per selected event.
- Plumb an explicit context delta status into the UI payload so the empty-state copy is accurate.
Contributor
Author
|
Summary:
Manual verification:
Tests:
|
noa-lucent
previously approved these changes
Feb 24, 2026
Contributor
noa-lucent
left a comment
There was a problem hiding this comment.
Summary:
- Verified lazy-loading now scopes LLM context fetches to the selected event.
- Confirmed context delta status is surfaced from the server and wired into UI payloads/tests.
Contributor
Author
|
Summary:
Tests:
|
noa-lucent
approved these changes
Feb 24, 2026
Contributor
noa-lucent
left a comment
There was a problem hiding this comment.
Summary:
- Verified limit parsing fix for LLM context pagination and added controller test coverage.
vitramir
approved these changes
Feb 24, 2026
casey-brooks
added a commit
that referenced
this pull request
Feb 25, 2026
* fix(ui): add context history action * fix(ui): add context delta status * feat(runs): add llm context pagination * fix(runs): lazy-load llm context * fix(agents): parse llm context limit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs #1322