Conversation
Contributor
Author
|
Also I should note it's a breaking change. This will force some new constraints on the user, but I consider it a lesser evil. |
|
I have actually a use case for this. I am working on a DataFrames library and will probably choose superrrecord for as a backend for some parts. Having CSVs with > 128 columns is not super uncommon. |
Owner
|
We will want to support this, but at the moment there are some problems with larger records that cause massive compile time slow downs. We have to investigate those first before we can drill down on this. |
|
okay, no rush. It's not even close to being finished. |
Contributor
Author
|
I've created an issue to dig into the compilation time blow-up, in a sense it blocks this PR(but maybe it isn't?) #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exact number of fields is statically known, so there's no other reason that performance to choose
SmallArray#overArray#. The issue withSmallArray#is an implicit maximum bound on the number of fields(<=128). Happily, it's possible to use multiple backends for the records of different size. Tests pass, but I want to add some new ones for the huge records specifically. Benchmarking won't hurt either.This change is