Fix Logger in Workflow #506
Conversation
Summary of ChangesHello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue with logger handling in Ray workflows by introducing a mechanism for process-global logger reuse within Ray actors. This change ensures that logging configurations, particularly log levels, are consistently applied across different concurrent workflow runners. The modifications are thoroughly validated with new tests that confirm the correct behavior of log message filtering and file output. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with logger instantiation in Ray workflows by introducing a process-global cache for the logger in trinity/utils/log.py. This ensures a single logger instance is reused within a Ray actor process. The changes are accompanied by a comprehensive test in tests/explorer/workflow_test.py that validates the logging behavior at different levels for remote actors. Additionally, the CHAT_TEMPLATE constant has been refactored from a test file into the shared tests/tools.py module for better organization.
My review focuses on improving the new test code. I've suggested correcting a typo in the log messages and using unittest's assertion methods for better test failure diagnostics. The core logic for the logger fix appears sound.
|
/unittest-module-explorer |
Summary
Failed Tests
Tests
Github Test Reporter by CTRF 💚 |
|
/unittest-pattern-TestConcurrentWorkflowRunner |
Summary
Tests
Github Test Reporter by CTRF 💚 |
|
/unittest-module-cli |
Summary
Failed Tests
Tests
Github Test Reporter by CTRF 💚 |
|
/unittest-pattern-test_debug_mode |
Summary
Tests
Github Test Reporter by CTRF 💚 |
|
/unittest-module-utils |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
2 participants
Description
As the title says
Checklist
Please check the following items before code is ready to be reviewed.