Improved getDependency workflow

[Amrutha-Kanhirathingal]

• getDependencies.pl script run twice.Once with customUrl. If it failed, retry with 3rd party URL.
• at jenkins level do the pre-stage getDependency only if env.BUILD_LIST == 'system'

Closes: #6461

[llxia]

This PR has to be merged with TKG PR: adoptium/TKG#758

[smlambert]

Same comment as in adoptium/TKG#758 (comment), CUSTOM_URL is too generic of a name to read the code and know what its purpose is, so I would rather see a more specific name used, in order to make the purpose clearer.

[Amrutha-Kanhirathingal]

Yes, I agree. The only concern is that this name customUrl(CUSTOM_URL = customUrl )is used across multiple places, so improving it would mean changing it in several places.

[karianna]

Yes, I agree. The only concern is that this name customUrl(CUSTOM_URL = customUrl )is used across multiple places, so improving it would mean changing it in several places.

Let's do it :-). Hopefully it's not overloaded!

[Amrutha-Kanhirathingal]

In that case We could use TEST_DEPENDENCY_URL instead of "CUSTOM_URL" since the getCustomurl is written in below way

https://github.com/adoptium/aqa-tests/blob/master/buildenv/jenkins/JenkinsfileBase#L1209-L1220

Please let me know if you guys have any concern
Thanks

[sophia-guo]

adoptium/TKG#758 is merged. We can have a separate PR to update customUrl name.

[smlambert]

Raised #6865 to capture the desire to improve the variable name.

[smlambert]

Approving with the request to improve the variable name in separate PR (#6865).