Skip to content

Reapply "MWPW-186852 Nala test: Version page (#597)" (#602)#609

Open
seanchoi-dev wants to merge 4 commits intomainfrom
MWPW-188322
Open

Reapply "MWPW-186852 Nala test: Version page (#597)" (#602)#609
seanchoi-dev wants to merge 4 commits intomainfrom
MWPW-188322

Conversation

@seanchoi-dev
Copy link
Contributor

This reverts commit ab6cf85.

Resolves https://jira.corp.adobe.com/browse/MWPW-188322
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases

Please do the steps below before submitting your PR for a code review or QA

  • C1. Cover code with Unit Tests
  • C2. Add a Nala test (double check with #fishbags if nala test is needed)
  • C3. Verify all Checks are green (unit tests, nala tests)
  • C4. PR description contains working Test Page link where the feature can be tested
  • C5: you are ready to do a demo from Test Page in PR (bonus: write a working demo script that you'll use on Thursday, you can eventually put in your PR)
  • C.6 read your Jira one more time to validate that you've addressed all AC's and nothing is missing

🧪 Nala E2E Tests

Nala tests run automatically when you open this PR.

To run Nala tests again:

  1. Add the run nala label to this PR (in the right sidebar)
  2. Tests will run automatically on the current commit
  3. Any future commits will also trigger tests as long as the label remains

To stop automatic Nala tests:

  • Remove the run nala label

Note: Tests only run on commits if the run nala label is present. Add the label whenever you need tests to run on new changes.

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Feb 19, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.74%. Comparing base (edab748) to head (0915ef5).

Files with missing lines Patch % Lines
studio/src/mas-side-nav.js 75.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   83.61%   83.74%   +0.12%     
==========================================
  Files         177      177              
  Lines       47796    47822      +26     
==========================================
+ Hits        39965    40048      +83     
+ Misses       7831     7774      -57     
Files with missing lines Coverage Δ
studio/src/version-page.js 51.39% <100.00%> (+0.32%) ⬆️
studio/src/mas-side-nav.js 66.27% <75.00%> (+0.73%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edab748...0915ef5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@afmicka afmicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename the version files (delete "-page" part from the names and call them all versions), and move them in a structured way as other tests. Move them under folder "versions" that has folders "specs" and "tests". In the spec file put the spec file, in the test folder put the test file and page.js in the root of the versions folder. See the same changes here https://github.com/adobecom/mas/pull/623/changes

Image

# Conflicts:
#	nala/studio/studio.page.js
#	nala/studio/versions/specs/versions.spec.js
#	nala/studio/versions/tests/versions.test.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants