Reapply "MWPW-186852 Nala test: Version page (#597)" (#602)#609
Reapply "MWPW-186852 Nala test: Version page (#597)" (#602)#609seanchoi-dev wants to merge 4 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
+ Coverage 83.61% 83.74% +0.12%
==========================================
Files 177 177
Lines 47796 47822 +26
==========================================
+ Hits 39965 40048 +83
+ Misses 7831 7774 -57
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
please rename the version files (delete "-page" part from the names and call them all versions), and move them in a structured way as other tests. Move them under folder "versions" that has folders "specs" and "tests". In the spec file put the spec file, in the test folder put the test file and page.js in the root of the versions folder. See the same changes here https://github.com/adobecom/mas/pull/623/changes
# Conflicts: # nala/studio/studio.page.js # nala/studio/versions/specs/versions.spec.js # nala/studio/versions/tests/versions.test.js
This reverts commit ab6cf85.
Resolves https://jira.corp.adobe.com/browse/MWPW-188322
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: