-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Implement Tag Mappings for Opportunities #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This PR will trigger a minor release when merged. |
29f2b5b to
4b06acf
Compare
anshulk-public
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tarunsinghdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
| HEADINGS: 'headings', | ||
| HREFLANG: 'hreflang', | ||
| INVALID_OR_MISSING_METADATA: 'meta-tags', | ||
| PRODUCT_METATAGS: 'product-metatags', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jfyi, this is a Adobe Commerce Optimizer only opportunity.
and would have isACO tag.
Do you also need to preserve that tag?
won't show up in ASO UI, fwik.
But, please cross-check.
Adding a constant here is fine, but just letting you know in case you have any changes related to this in other PRs
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!