fix: resolve CI failures from GetSignalsRequest union alias#144
Merged
fix: resolve CI failures from GetSignalsRequest union alias#144
Conversation
Pydantic hard-rejects model_config['extra'] on RootModel subclasses, which broke the documented pattern of subclassing library types with env-based config. Adding a plain union alias in aliases.py shadows the generated RootModel wrapper, restoring the ability for consumers to subclass GetSignalsRequest1 or GetSignalsRequest2 with custom model_config. Closes #138 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Shorten docstring in aliases.py to fix ruff E501 line-too-long error - Fix simple.py to dispatch GetSignalsRequest variants via model_validate instead of calling the union type as a constructor (mypy operator error) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These directories contain dev tooling and examples, not published code. CI already only lints src/, so this makes the local config consistent. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aliases.pythat was 1 character over the ruff E501 line length limit (101 > 100)simple.pyto dispatch betweenGetSignalsRequestvariants usingmodel_validateinstead of calling the union type as a constructor, which caused a mypyoperatorerrorTest plan
ruff check src/passesmypy src/adcp/passes (0 errors, 377 files)pytest tests/passes (654 passed)🤖 Generated with Claude Code