Merged
Conversation
- Pin ADCP_VERSION to 3.0.0-rc.1 (from latest) - Sync 328 schemas from adcontextprotocol.org/schemas/3.0.0-rc.1 - Regenerate Pydantic types from updated schemas - Fix ergonomic coercion generator to apply FieldModel coercion to GetProductsRequest1/2/3 variants (was imported but never wired) - Add test for GetMediaBuysRequest.account being optional (v3 change) Key schema changes: - get-media-buys-request: account is now optional (was required) - get-products-request: buying_mode descriptions include v3 migration note - core/provenance: AiTool.version should use model version not API version - Various buyer_ref description updates Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADCP_VERSIONto3.0.0-rc.1(waslatest)adcontextprotocol.org/schemas/3.0.0-rc.1(10 schemas updated)Schema changes in 3.0.0-rc.1
get-media-buys-request:accountfield is now optional (was required) — enables querying across all accessible accountsget-products-request:buying_modedescriptions include v3 migration guidance for sellers handling pre-v3 clientscore/provenance:AiTool.versiondescription clarifies to use model version rather than API versionbuyer_refdescription updates in media buy schemasAlso fixed
generate_ergonomic_coercion.py:GetProductsRequestis aRootModelwrapper — the generator was importingFieldModel/GetProductsRequestbut analyzing the wrong class (no fields found). Fixed to analyze and apply coercion to the concrete variantsGetProductsRequest1/2/3, sofields=["product_id", "name"]now works ergonomically on all buying modes.GetMediaBuysRequest.accountbeing optional per the schema change.Test plan
3.0.0-rc.1endpoint🤖 Generated with Claude Code