Relax container image schema and add custom validation

[ericsciple]

Related PR:

• Fix parser comparison mismatches runner#4220

Relaxing schema non-empty-string for container/service image and moving to custom validation. This matches current production behavior which allows empty string at runtime, but not parse time.

Parse Time Behavior

YAML	Result
container: ''	Silent (null)
container: 'docker://'	Error
container: {}	Error
container: {image: ''}	Error
container: {image: 'docker://'}	Error
container: {image: '', options: ${{ expr }}}	Error
services: {svc: ''}	Error
services: {svc: 'docker://'}	Error
services: {svc: {}}	Error
services: {svc: {image: ''}}	Error

[Copilot]

Pull request overview

This pull request relaxes the JSON schema validation for container and service image properties and adds custom validation logic to match production runtime behavior. The schema type is changed from "non-empty-string" to "string", allowing empty strings to pass schema validation, while custom validation in the converter layer enforces the appropriate rules.

Changes:

• Schema relaxation: Changed container/service image type from "non-empty-string" to "string" in workflow-v1.0.json
• Custom validation: Implemented detailed validation logic in container.ts that handles empty strings, docker:// prefixes, expressions, and the distinction between job containers (silent on empty) and service containers (error on empty)
• Error handling: Added handleTemplateTokenErrors wrapper to container and services conversion calls in job.ts
• Comprehensive test coverage: Added 31 test cases covering shorthand/mapping forms, expression safety, and all error scenarios

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
workflow-parser/src/workflow-v1.0.json	Changed container and service image schema type from "non-empty-string" to "string" to allow empty strings at parse time
workflow-parser/src/model/converter/container.ts	Implemented custom validation for container images including empty string detection, docker:// prefix handling, expression key/value handling, and isServiceContainer flag support
workflow-parser/src/model/converter/job.ts	Wrapped convertToJobContainer and convertToJobServices calls with handleTemplateTokenErrors for proper error handling
workflow-parser/src/model/converter/container.test.ts	Added comprehensive test suite with 31 test cases covering all validation scenarios and expression safety
workflow-parser/testdata/skipped-tests.txt	Added job-container-invalid.yml to skipped tests list

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.