Conversation
Collaborator
Author
|
I'm very unclear what this patch does. The contributor wasn't clear and I didn't stare at it enough to be sure what it does. |
atoomic
force-pushed
the
master
branch
5 times, most recently
from
0c2da20 to
e0d5f00
Compare
Resolves GH #98 TT does not save compiled on-fly templates to disk (only saves firs- time compiled) and second line - for help hacking via redefining functions for bases, preprocessing,..
atoomic
approved these changes
Apr 28, 2024
Koan-Bot
added a commit
to atoomic/Template2
that referenced
this pull request
Feb 14, 2026
When COMPILE_DIR/COMPILE_EXT is configured, the first compile of a template correctly writes the compiled Perl code to disk. However, when the template source file is later modified and _refresh() recompiles it, the call to _compile() was missing the compiled filename argument. This meant the recompiled template was only stored in memory, never persisted to disk. On the next cold start, the stale compiled file would be loaded instead of the updated source, leading to incorrect template output until the compiled file was manually deleted. Fix: pass _compiled_filename() to _compile() in _refresh(), matching the behavior already used in _fetch(). Resolves: abw#98 See also: abw#197 Co-Authored-By: Kōan <noreply@anthropic.com>
This was referenced Feb 14, 2026
Collaborator
|
moved to #334 which provides tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves GH #98
TT does not save compiled on-fly templates to disk (only saves firs-
time compiled)
and second line - for help hacking via redefining functions for bases,
preprocessing,..