Wait for device to connect in avrdude module.#29
Open
NicoHood wants to merge 2 commits intoabcminiuser:masterfrom
Open
Wait for device to connect in avrdude module.#29NicoHood wants to merge 2 commits intoabcminiuser:masterfrom
NicoHood wants to merge 2 commits intoabcminiuser:masterfrom
Conversation
Owner
|
Thanks for the patch. I just did a quick test and this doesn't seem to behave on Windows - the |
Contributor
Author
|
You can try |
Owner
|
No bueno. Apparently under Cygwin/MinGW, COM ports aren't mapped to the same DOS style device names as the native command line shell (so while a utility can open a file |
Contributor
Author
|
Hm I have no idea how this works on windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was created especially for serial bootloaders. Sometimes it takes some time after reset for them to show up (CDC USB Bootloader). With this patch the module waits for the device to connect and then flashes it. This is way more comfort and also used similar in the arduino IDE.
I did not add a timeout for simplicity. If avrdude hangs, there is also no timeout. A special check for usb "ports" were added in order to not break them.