-
Notifications
You must be signed in to change notification settings - Fork 470
Feat/mantle chainid #2845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/mantle chainid #2845
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7f5a65ddb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pages/api/rpc-proxy.ts
Outdated
| [ChainId.mantle]: { | ||
| network: 'mantle-mainnet', | ||
| apiKey: process.env.MANTLE_RPC_API_KEY || 'https://rpc.mantle.xyz', | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use valid Alchemy key or handle full RPC URL
When MANTLE_RPC_API_KEY is unset, this falls back to the full https://rpc.mantle.xyz URL, but getRpcUrl always interpolates the value into an Alchemy URL (https://mantle-mainnet.g.alchemy.com/v2/${apiKey}). That produces an invalid endpoint like https://mantle-mainnet.g.alchemy.com/v2/https://rpc.mantle.xyz, so mantle RPC calls will fail in any environment without the env var set. If Mantle should use a non‑Alchemy RPC, getRpcUrl needs to accept full URLs or NETWORK_CONFIG should store a rpcUrl instead of an apiKey for this chain.
Useful? React with 👍 / 👎.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
General Changes
Developer Notes
Add any notes here that may be helpful for reviewers.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files