Skip to content

Conversation

@foodaka
Copy link
Collaborator

@foodaka foodaka commented Jan 25, 2026

General Changes

  • Fixes XYZ bug
  • Adds XYZ feature

Developer Notes

Add any notes here that may be helpful for reviewers.


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

@vercel
Copy link

vercel bot commented Jan 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
interface Ready Ready Preview, Comment Jan 25, 2026 9:20pm

Request Review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7f5a65ddb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 30 to 33
[ChainId.mantle]: {
network: 'mantle-mainnet',
apiKey: process.env.MANTLE_RPC_API_KEY || 'https://rpc.mantle.xyz',
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use valid Alchemy key or handle full RPC URL

When MANTLE_RPC_API_KEY is unset, this falls back to the full https://rpc.mantle.xyz URL, but getRpcUrl always interpolates the value into an Alchemy URL (https://mantle-mainnet.g.alchemy.com/v2/${apiKey}). That produces an invalid endpoint like https://mantle-mainnet.g.alchemy.com/v2/https://rpc.mantle.xyz, so mantle RPC calls will fail in any environment without the env var set. If Mantle should use a non‑Alchemy RPC, getRpcUrl needs to accept full URLs or NETWORK_CONFIG should store a rpcUrl instead of an apiKey for this chain.

Useful? React with 👍 / 👎.

@foodaka foodaka merged commit 9fd91a4 into main Jan 25, 2026
10 checks passed
@foodaka foodaka deleted the feat/mantle-chainid branch January 25, 2026 21:20
@github-actions
Copy link

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants