Replace serde_derive with serde/derive#271
Merged
aatxe merged 1 commit intoaatxe:developfrom Jan 25, 2025
Merged
Conversation
aatxe
approved these changes
Jan 25, 2025
Owner
aatxe
left a comment
There was a problem hiding this comment.
I think I'm okay with this, derive was never really intended on being optional separately from serde, but uhh... Hyrum's law, I suppose. So, hello to whoever this PR broke.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian autopkgtests is very eager in trying to find all possible combinations, and tries to build the crate with
cargo check --no-default-features --features serde, which currently doesn't work.I'm patching this downstream, this change removes the need for that patch.
In theory this is a breaking change, in case somebody uses (for whatever reason):
this would not work anymore, you could work around this by having a feature named "serde_derive" that does nothing: