feat: precomp attrs and write_annotations refinements#879
feat: precomp attrs and write_annotations refinements#879
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 143 143
Lines 6130 6135 +5
=========================================
+ Hits 6130 6135 +5 ☔ View full report in Codecov by Sentry. |
41e1649 to
7d091da
Compare
| chunk_sizes: Sequence[Sequence[int]] | ||
| path: str = "" | ||
|
|
||
| def __init__( |
There was a problem hiding this comment.
The canonical way to do it is to still use attrs.define(init=True) and add an __attrs_post_innit__ that performs complex checks and re-sets variables.
|
@JoeStrout is this still relevant to be merged or did we evolve away from that? |
|
Ugh. Some of this is still relevant, but will conflict heavily with the refactoring we did (in another branch, now merged) converting AnnotationLayer into a VolumetricBackend. I'll have to redo the relevant bits by hand, but at this point I should do that after merging all the other outstanding code. |
attrsAnnotationLayer.write_annotationsnow raises aValueErrorif you supply a bounding box to clear, and any annotations are partially or fully outside that bounds