Fixed a shallow copy to the rank color variable#174
Draft
bellum128 wants to merge 1 commit intoXandaros:masterfrom
Draft
Fixed a shallow copy to the rank color variable#174bellum128 wants to merge 1 commit intoXandaros:masterfrom
bellum128 wants to merge 1 commit intoXandaros:masterfrom
Conversation
…other addons accessing its alpha value
Contributor
Author
|
I apparently didn't retest this without our custom chat addon, and it causes issues; will look into that at some point... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way the alpha value was set for the overhead nameplates plugin was inadvertently creating a shallow copy, causing the actual rank color variable to be modified. This was causing an issue when attempting to integrate Evolve's rank colors into other addons, as that alpha variable would carry over into the other addon as players faded from view.