fix: Update files to make build pass #3734
Draft
+1,109
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mannycarrera4
commented
Jan 30, 2026
alanbsmith
changed the title
alanbsmith
reviewed
Jan 30, 2026
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
| const require = createRequire(import.meta.url); | ||
|
|
||
| // // we use TS files, so tell node to register them |
Member
There was a problem hiding this comment.
Suggested change
| // // we use TS files, so tell node to register them | |
| // We use TS files, so tell node to register them |
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-fix-build-major
|
| Run status |
|
| Run duration | 02m 17s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
15
|
Skipped
|
0
|
Passing
|
802
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.52%
|
|
|---|---|
|
Untested elements
|
1515
|
|
Tested elements
|
365
|
Accessibility
99.47%
|
|
|---|---|
|
Failed rules
|
5 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
71
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #1234
Release Category
Components
Release Note
When we merged this PR to upgrade Storybook and support ESM, our release broke here.
sb extractisn't even referenced in Storybook docs. We usedextractto generate astories.jsonwhich isn't a thing anymore based on the docs here. TILstorybook buildwill create aindex.jsonin favor of astories.jsonyarn buildstep. Running locally, this failed with a few errors because certain modules/packages weren't fully set up to support ESM, the docs package being one of them."type": "module"from root package.json, docs, and styling packages"type": "module"to CSS-only packages (canvas-kit-css, canvas-kit-labs-css, canvas-kit-preview-css).mjsversions of build utilities for proper ESM/CJS interopThis PR updates files and packages to ensure storybook gets built and our code gets built.
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)