Skip to content

Update jquery.ui.touch-punch.js as per https://core.trac.wordpress.org/ticket/54034#3812

Open
RWAP wants to merge 3 commits intoWordPress:trunkfrom
RWAP:trunk
Open

Update jquery.ui.touch-punch.js as per https://core.trac.wordpress.org/ticket/54034#3812
RWAP wants to merge 3 commits intoWordPress:trunkfrom
RWAP:trunk

Conversation

@RWAP
Copy link

@RWAP RWAP commented Jan 1, 2023

Updates early version (which has not been updated in many years and contains many bugs). Uses the code from maintained version: https://github.com/RWAP/jquery-ui-touch-punch/blob/master/jquery.ui.touch-punch.js

The touch-punch Code has been tested on a wide range of touch devices to allow touch devices to use mouse controls in jQuery UI

For changes and issues - please submit to the original repository: https://github.com/RWAP/jquery-ui-touch-punch/blob/master/jquery.ui.touch-punch.js

Updates early version (which has not been updated in many years and contains many bugs).  Uses the code from maintained version: 
https://github.com/RWAP/jquery-ui-touch-punch/blob/master/jquery.ui.touch-punch.js 

Code has been tested on a wide range of touch devices to allow touch devices to use mouse controls in jQuery UI

For changes and issues - please submit to the original repository:
https://github.com/RWAP/jquery-ui-touch-punch/blob/master/jquery.ui.touch-punch.js
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Hi @RWAP! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RWAP for the PR!

Can you please update the script version here: https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/script-loader.php#L906

Reflect change to jquery.ui.touch-punch.js in the script loader
@RWAP
Copy link
Author

RWAP commented Jan 2, 2023

OK I have updated the version number also in the script-loader.php

@peterwilsoncc
Copy link
Contributor

@RWAP Thanks for the patch, is the correct as the change log for the uncompressed code? furf/jquery-ui-touch-punch@master...RWAP:jquery-ui-touch-punch:master

@RWAP
Copy link
Author

RWAP commented Mar 23, 2023

@RWAP Thanks for the patch, is the correct as the change log for the uncompressed code? furf/jquery-ui-touch-punch@master...RWAP:jquery-ui-touch-punch:master

No - as the old code has not been maintained and no-one looks after the repository, it seemed better to treat it as a brand new bit of code:

https://github.com/RWAP/jquery-ui-touch-punch

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @RWAP.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, mukesh27, peterwilsoncc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
Copy link
Member

desrosj commented Feb 17, 2026

Since there were no merge conflicts, I've gone and updated the branch with the latest from trunk. Though it seems there is likely another version of the library available, so this will need to be updated.

@RWAP I think what @peterwilsoncc is looking for is a link that shows all of the changes between the version included in WP Core today and the version included in this pull request. That's important for Core Committers to comb through just to make sure everything seems compatible and that there are no concerns.

Would it be possible for you to begin tagging releases in GitHub as well? That makes it much easier to track changes release to release.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants