This repository was archived by the owner on Feb 5, 2026. It is now read-only.
Merged
Conversation
29dc92f to
c97f8bf
Compare
c97f8bf to
d4af415
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
justlevine
commented
Aug 13, 2025
Co-authored-by: Dovid Levine <justlevine@gmail.com>
gziolo
reviewed
Aug 14, 2025
gziolo
approved these changes
Aug 14, 2025
Member
gziolo
left a comment
There was a problem hiding this comment.
That's a nice improvement. We can address the rest of reported issues in follow-up PRs. I like how it helps to catch some small things in the code 💯
Member
This was an actual error that I fixed in f762155. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This is a first pass of PHPStan/PHPCS remediations. Most were auto-fixed, a couple (like moving the file headers above the
declare_strict()),Some tweaks to the
phpcs.xml.distas well, due to some accidental conflicts when I was deduping rulesets.Follow up to #4
Remaining smells are:
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedFunctionFound- do we want a namespace?WordPress.WP.I18n.MissingArgDomain- do we want this translatable before merged into core?And then some things that need actual remediation (using
WP_Abilityas a string) or a decision about if we want to suppress/fix/turn off the rule.Why