Panel : Unify icon sizes #328
Open
+96
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, icons of widgets will now follow the size of the panel.
Adds a css config for a default size for icons, which is overriden by the configuration entry for each icon if it is not 0. Meanwhile, the default becomes 0.
Adjusted the panel’s default height to keep it’s height the same as the default configuration (42, due to that being the menu widget’s value), though it does lead to other widgets being by slightly bigger. Not sure if this is a deal breaker and they should retain their 32 default or not.
The icon size of launchers was getting applied to the menu widget as well, probably because it didn’t have a config option of it’s own. Added one.
This also fixes command-output’s size not actually being accounted for.
Example/default ini file has not yet been changed for any of this.
Also, potential breaking change we could for the sake for name consistency, if we value this more than not breaking things (probably not very wise but it annoys me personally) : rename laucher’s icon size
launchers_sizetolaunchers_icon_size.Addresses #269