Skip to content

Require POST to use the zip endpoint #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mike-kaimika wants to merge 1 commit into
base: release/4.5.0
Choose a base branch
from
Open

Require POST to use the zip endpoint #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ifcbdb/assets/js/bin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,11 @@ function updateBinDownloadLinks(data) {
$("#download-adc").attr("href", infix + _bin + ".adc");
$("#download-hdr").attr("href", infix + _bin + ".hdr");
$("#download-roi").attr("href", infix + _bin + ".roi");
$("#download-zip").attr("href", infix + _bin + ".zip");
$("#download-zip-form").attr("action", infix + _bin + ".zip");
$("#download-zip").click(function(e) {
e.preventDefault();
$("#download-zip-form").submit();
});
$("#download-blobs").attr("href", infix + _bin + "_blob.zip");
$("#download-features").attr("href", infix + _bin + "_features.csv");
$("#download-class-scores").attr("href", infix + _bin + "_class_scores.csv");
Expand Down
10 changes: 7 additions & 3 deletions ifcbdb/dashboard/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,15 +721,19 @@ def class_scores_csv(request, dataset_name, bin_id):
resp['Content-Disposition'] = 'attachment; filename={}'.format(filename)
return resp

def zip(request, bin_id, **kw):
@require_POST
def zip(request, bin_id, **kwargs):
b = get_object_or_404(Bin, pid=bin_id)
if 'dataset_name' in kw:
bin_in_dataset_or_404(b, kw['dataset_name'])

if 'dataset_name' in kwargs:
bin_in_dataset_or_404(b, kwargs['dataset_name'])
try:
zip_buf = b.zip()
except KeyError:
raise Http404("raw data not found")

filename = '{}.zip'.format(bin_id)

return FileResponse(zip_buf, as_attachment=True, filename=filename, content_type='application/zip')


Expand Down
3 changes: 3 additions & 0 deletions ifcbdb/templates/dashboard/bin.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,6 +553,9 @@
<li><a id="download-roi" href="#">ROI</a></li>
<li><a id="download-zip" href="#">ZIP</a></li>
</ul>
<form id="download-zip-form" method="post" target="_blank">
{% csrf_token %}
</form>
</div>
<div class="flex-column flex-fill">
<ul class="list-unstyled">
Expand Down