Rename namespace from com.hoker.intra to com.vivokey.intra#1
Open
Rename namespace from com.hoker.intra to com.vivokey.intra#1
Conversation
Breaking Changes: - Package namespace changed from com.hoker.intra to com.vivokey.intra - All imports must be updated in consuming applications - Library version bumped to 2.0.0 API Changes: - Replace deprecated /session endpoint with /authenticate - getVivokeyJwt() now requires devId parameter - Remove SessionRequest/SessionResponse (deprecated) - Add AuthenticateRequest/AuthenticateResponse for new JWE flow - NetworkModule now uses api.vivokey.com base URL - Remove hardcoded API key from NetworkModule (not needed for mobile) The new /authenticate flow returns encrypted JWEs that must be decrypted server-side using the paired API key. Mobile apps only need the developer ID, not the API key. Updated example app to use new namespace and devId parameter.
The api.vivokey.com endpoint is legacy/decommissioned. The correct base URL is https://auth.vivokey.com/
- Add missing return statement in connect() for IsodepControllerImpl, NfcAControllerImpl, and NfcVControllerImpl. Without the return, the let block result was discarded and Failure was always returned. - Add null safety checks for response and tag.id in NfcVControllerImpl getVivokeyJwt() to prevent null pointer exceptions during NFC scans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
com.hoker.intratocom.vivokey.intra/sessionendpoint with/authenticatefor new JWE flowgetVivokeyJwt()to requiredevIdparameterBreaking Changes
All imports must be updated from
com.hoker.intra.*tocom.vivokey.intra.*API Changes
getVivokeyJwt(tag)getVivokeyJwt(tag, devId)/sessionendpoint/authenticateendpointSessionRequestAuthenticateRequest(withdev_idfield)SessionResponseAuthenticateResponseNew Authentication Flow
The new
/authenticateendpoint returns encrypted JWEs instead of plain JWTs:/challengeto get PCD challenge/authenticatewithdev_id/verifyTest plan
/authenticate