Open
Conversation
pablo-bossi
commented
May 22, 2020
Author
pablo-bossi
left a comment
pablo-bossi
left a comment
There was a problem hiding this comment.
Checked with a local project and files got generated properly
composer.json
Outdated
| "require": { | ||
| "php": "^7.0", | ||
| "laravel/framework": "~5.6" | ||
| "laravel/framework": "~6.18" |
composer.json
Outdated
| "require-dev": { | ||
| "phpunit/phpunit": "~6.0", | ||
| "mockery/mockery": "0.9.*" | ||
| "phpunit/phpunit": "~8.0", |
Author
There was a problem hiding this comment.
Updated phpunit version required for laravel 6
| "phpunit/phpunit": "~6.0", | ||
| "mockery/mockery": "0.9.*" | ||
| "phpunit/phpunit": "~8.0", | ||
| "mockery/mockery": "1.3.*" |
Author
There was a problem hiding this comment.
updated mockery to meet phpUnit 8 needs
| $dummyname = $this->dummynameRepository->create($data); | ||
|
|
||
| $this->dispatcher->fire(new DummyModelWasCreated($dummyname)); | ||
| $this->dispatcher->dispatch(new DummyModelWasCreated($dummyname)); |
Author
There was a problem hiding this comment.
Since laravel 5 fire has been deprecated in favor of dispatch, so updating it so generated services remains working properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.