Replaced DB query with eloquent so query uses model's $connection#433
Open
himanshu-bhalala-24 wants to merge 16 commits intoVentureCraft:developfrom
Open
Replaced DB query with eloquent so query uses model's $connection#433himanshu-bhalala-24 wants to merge 16 commits intoVentureCraft:developfrom
himanshu-bhalala-24 wants to merge 16 commits intoVentureCraft:developfrom
Conversation
use larger integers for ID's and in down function change to dropIfExists, to prevent a potential failure
remove misleading space (not being trimmed in model)
doc: userResponsible returns false and not null.
Laravel 11.x Compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing a DB query with Eloquent ensures the query utilizes the Revision model's $connection property, which defines the database connection. This helps if we want to use different database connection for revisions table.