Created date parsing and reconciliation systems for robust date handling.#548
Open
Created date parsing and reconciliation systems for robust date handling.#548
Conversation
fcogidi
reviewed
Jan 19, 2024
Collaborator
There was a problem hiding this comment.
Please clean up this module a bit - function type annotations, docstrings, and removal of unused commented out code.
| import numpy as np | ||
| import pandas as pd | ||
|
|
||
| from cyclops.data.df.series_validation import to_frame_if_series |
Collaborator
There was a problem hiding this comment.
The to_frame_if_series method is missing from the original code. Please add.
| return pd.concat([date_comps, time_comps], axis=1) | ||
|
|
||
|
|
||
| # def find_dates(text): |
Collaborator
There was a problem hiding this comment.
Did you want to keep this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type ([Feature | Fix | Documentation | Test])
Feature
Short Description
Added robust component-wise date parsing. Added date reconciliation wherein typos and systemic date entry errors can be identified.
Note: Proper integration required.