Merged
Conversation
nickamzol
added
service:wado-rs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| impl IntoResponse for RetrieveError { | ||
| fn into_response(self) -> Response { | ||
| match self { | ||
| RetrieveError::Backend { source } => { |
Check warning
Code scanning / clippy
unnecessary structure name repetition Warning
| impl IntoResponse for RetrieveError { | ||
| fn into_response(self) -> Response { | ||
| match self { | ||
| RetrieveError::Backend { source } => { |
Check warning
Code scanning / clippy
unnecessary structure name repetition Warning
| RetrieveError::Backend { source } => { | ||
| (StatusCode::INTERNAL_SERVER_ERROR, source.to_string()).into_response() | ||
| } | ||
| RetrieveError::Unimplemented => Response::builder() |
Check warning
Code scanning / clippy
unnecessary structure name repetition Warning
| RetrieveError::Backend { source } => { | ||
| (StatusCode::INTERNAL_SERVER_ERROR, source.to_string()).into_response() | ||
| } | ||
| RetrieveError::Unimplemented => Response::builder() |
Check warning
Code scanning / clippy
unnecessary structure name repetition Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering is no longer exclusive to the DIMSE backend and works across all backends now.
Existing implementations of
WadoService::renderhave been changed to return anUnimplementederror, which causes the server to use the default render implementation as a fallback.The default implementation retrieves instances using
WadoService::retrieveand renders them on the fly using the existing rendering code. Future backends can overrideWadoService::renderto bypass the default implementation and serve pre-rendered images or use a custom renderer.