0.8.0 The Great Refactor #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be sure to update your code to use the new decoded format, keys on parsed XML are no longer atoms (for safety reasons) The primary reason for this change is to prevent a possible memory leak from server crafted XML documents that would exhaust the atom limit, in the first place parsing XML to unsafe atoms was a BAD IDEA.
IceDragon200
force-pushed
the
full-active-conn
branch
from
fe29a4e to
49fbb68
Compare
I'd love to get to the bottom of this, but for now, handle the error quietly. I suspect this happens when the recv_size is exceeded and the file is unceremoniously killed
Also don't trap exits, let them die normally
Elixir 1.18 detected the mismatch responses
It can still be designated with the chunked tuple on the stream
… encoding behaviour This is to get around issues with servlet style arrays where the key needs to be repeated
The old implementation breaks on bag and duplicate_bag tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the CHANGELOG for an overview
One thing that has come to light during this refactor is the rather slow performance of HTTP/2, it could be mint or it could be something else entirely, but it's a whole 42ms slower, which is significant if you're trying to burst traffic over it