Fix convex function ignoring given properties#2972
Open
blchelle wants to merge 5 commits intoTurfjs:masterfrom
Open
Fix convex function ignoring given properties#2972blchelle wants to merge 5 commits intoTurfjs:masterfrom
blchelle wants to merge 5 commits intoTurfjs:masterfrom
Conversation
2 tasks
Author
|
@smallsaucepan would you be able to take a look at this PR when you have a chance? |
Author
|
@smallsaucepan do you need anything from me to help get this PR merged? |
smallsaucepan
requested changes
Feb 1, 2026
Member
smallsaucepan
left a comment
There was a problem hiding this comment.
Thanks for putting this together. Couple of small things to change / check.
smallsaucepan
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Using the convex function to combine a feature collection returns a newly constructed polygon with missing properties. This is crucial if the caller of the function attempts to pass additional properties to the end polygon.
PR includes a test to test this scenario and improved typing
Resolve #2762
contributorsfield ofpackage.json- you've earned it! 👏