Skip to content

Fix convex function ignoring given properties#2972

Open
blchelle wants to merge 5 commits intoTurfjs:masterfrom
blchelle:fix/#2762-convex-ignores-properties
Open

Fix convex function ignoring given properties#2972
blchelle wants to merge 5 commits intoTurfjs:masterfrom
blchelle:fix/#2762-convex-ignores-properties

Conversation

@blchelle
Copy link

Background

Using the convex function to combine a feature collection returns a newly constructed polygon with missing properties. This is crucial if the caller of the function attempts to pass additional properties to the end polygon.

PR includes a test to test this scenario and improved typing

Resolve #2762

  • Meaningful title, including the name of the package being modified.
  • Summary of the changes.
  • Heads up if this is a breaking change.
  • Any issues this resolves.
  • Inclusion of your details in the contributors field of package.json - you've earned it! 👏
  • Confirmation you've read the steps for preparing a pull request.

@kareemjeiroudi
Copy link

Thanks @blchelle for taking over. I'll close this PR #2765, as soon as yours is merged 👍.

@blchelle
Copy link
Author

blchelle commented Jan 5, 2026

@smallsaucepan would you be able to take a look at this PR when you have a chance?

@blchelle
Copy link
Author

@smallsaucepan do you need anything from me to help get this PR merged?

Copy link
Member

@smallsaucepan smallsaucepan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. Couple of small things to change / check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

turf.convex ignores given properties

3 participants