Binary mode: Add support for importing reports#37
Merged
martinjaeger merged 1 commit intoThingSet:mainfrom Feb 3, 2025
Merged
Conversation
Contributor
martinjaeger
left a comment
There was a problem hiding this comment.
Thanks for this nice addition.
Only got two minor comments.
c22ea45 to
58fba53
Compare
58fba53 to
ef032dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable multiple devices to exchange structured data by adding the ability to interpret binary reports received from other systems.
For an example of its usage, see: Example: Importing Reports.
This implementation may address LibreSolar/bms-c1#63.