Draft:[18.0][RFR] #12975 Review automated action #6
Conversation
oca_custom/models/res_partner.py
Outdated
| if chan_id: | ||
| desired_channel_ids.add(chan_id) | ||
|
|
||
| for chan in channels: |
There was a problem hiding this comment.
Better to use complete name:
channel
There was a problem hiding this comment.
I had made this feature but checking on Tom's requirement he mentioned he will come up with a better way.
| elif (not should_be_member) and is_member: | ||
| self._safe_channel_write(chan, {field: [(3, partner.id)]}) | ||
|
|
||
| def action_membership_sync(self): |
There was a problem hiding this comment.
Is this called anywhere apart from the tests?
or it can be added as a server action by hand?
There was a problem hiding this comment.
I was using it with the base automation but made a server action for partner Sync Member Tag from Membership which you can use. I also added a cron job which can be called on intervals.
oca_custom/models/res_partner.py
Outdated
| _logger = logging.getLogger(__name__) | ||
|
|
||
| PARAM_PREFIX = "oca_membership_channel_sync." | ||
| MEMBER_STATES = {"paid", "invoiced", "free"} |
There was a problem hiding this comment.
I think it should only be paid & Free.
but let's confirm from Tom.
There was a problem hiding this comment.
I removed free and invoiced and just settled for paid based on the scope Tom mentioned.
| return res | ||
|
|
||
| if "membership_state" in vals: | ||
| self._sync_member_tag_from_membership_state() |
There was a problem hiding this comment.
Even after paying for a membership, I couldn't get the tag configured to be added.
There was a problem hiding this comment.
@Kiplangatdan can you try again and make sure the member is none if you're creating a new test member
KKamaa
force-pushed
the
18.0-12975-auto-code-RFR
branch
from
d5a8d74 to
666b6ed
Compare
Refactor automated action Update Tag and Mailing list -> Update Mailing List