Skip to content

feat: enhance LLM dev workflow#58

Merged
TheTrueAI merged 1 commit intomainfrom
enhance-llm-dev-workflow
Mar 2, 2026
Merged

feat: enhance LLM dev workflow#58
TheTrueAI merged 1 commit intomainfrom
enhance-llm-dev-workflow

Conversation

@TheTrueAI
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 2, 2026 00:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens and documents the developer/agent workflow for Immermatch, while applying small refactors driven by stricter linting and improving CI expectations.

Changes:

  • Consolidates runtime dependencies into base pyproject.toml (removing the prod extra) and updates workflows accordingly.
  • Enables additional Ruff rule families (B, C4, SIM, RET) and applies small code refactors to satisfy them.
  • Adds/updates agent + Copilot guidance docs (CLAUDE quick reference + Copilot prompt files) and raises CI coverage threshold.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_app_consent.py Adjusts exception chaining to satisfy stricter linting (Bugbear-style guidance).
pyproject.toml Removes prod extra, expands Ruff lint selection, keeps test/dev extras.
immermatch/serpapi_provider.py Simplifies localise_query() return to align with return-style lint rules.
immermatch/pages/verify.py Replaces try/except with contextlib.suppress for secrets→env injection.
immermatch/pages/unsubscribe.py Same contextlib.suppress refactor for secrets→env injection.
immermatch/pages/privacy.py Same contextlib.suppress refactor for secrets→env injection.
immermatch/pages/impressum.py Same contextlib.suppress refactor for secrets→env injection.
immermatch/bundesagentur.py Minor parsing simplification and flattens executor context management.
immermatch/app.py Refactors secrets→env injection to contextlib.suppress.
CLAUDE.md Replaces prior stub with a quick-reference agent guide.
AGENTS.md Updates testing table and clarifies CLAUDE.md’s role; adds ruff format --check.
.github/workflows/daily-digest.yml Installs package without .[prod] extra (now removed).
.github/workflows/ci.yml Raises coverage threshold from 50% → 60%.
.github/copilot/write-tests.prompt.md Adds Copilot prompt guidance for tests (contains a couple incorrect patch targets).
.github/copilot/new-pydantic-model.prompt.md Adds Copilot prompt guidance for models (contains incorrect list-default guidance).
.github/copilot/new-db-function.prompt.md Adds Copilot prompt guidance for DB functions.
.github/copilot-instructions.md Updates Copilot instructions, adds architecture summary and formatting check.
Comments suppressed due to low confidence (3)

.github/copilot/new-pydantic-model.prompt.md:13

  • The guidance to use = [] for list defaults is unsafe (mutable default) and also contradicts this repo’s current Pydantic patterns, which consistently use Field(default_factory=list) for lists. Update this instruction to recommend default_factory=list (or Field(default_factory=list, ...)) for list fields to avoid shared mutable defaults.
3. **Default values:** Use `= []` for simple lists, `default_factory=list` for mutable defaults in `Field()`
4. **Add tests in `tests/test_models.py`:**

.github/copilot/write-tests.prompt.md:9

  • immermatch/serpapi_provider.py doesn’t define serpapi_search; the external call is made via GoogleSearch (or you can patch search_jobs). Update this patch target so tests don’t fail with an AttributeError / ineffective mocking.
   - SerpApi: `@patch("immermatch.serpapi_provider.serpapi_search")`

.github/copilot/write-tests.prompt.md:10

  • immermatch/bundesagentur.py uses httpx.Client, not requests.get. Update the suggested patch target to something that actually intercepts network calls (e.g., patch httpx.Client.get in the module under test, or patch BundesagenturProvider._get_with_retry / _fetch_detail*).
   - Bundesagentur: `@patch("immermatch.bundesagentur.requests.get")`

@TheTrueAI TheTrueAI merged commit 8c2abd1 into main Mar 2, 2026
8 checks passed
@TheTrueAI TheTrueAI deleted the enhance-llm-dev-workflow branch March 2, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants