Open
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
294c2e7 to
16839e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
MTProxy crashed due to
assert (!(p & 0xffff0000))ininit_common_PID: the code assumed PID always fits in 16 bits. On systems withpid_max> 65535 (e.g. pid 94936, 95241), the assert triggeredand the proxy crashed.
Solution (workaround)
Removed the assert and store only the lower 16 bits of the PID instead of the full value:
PID.pid = (unsigned short) (p & 0xffff);
Why not 32 bits
This is a workaround. Ideally we would pass a 32-bit pid, but that is not possible:
process_idis serialized in the RPC handshake between MTProxy and Telegram DC serversSo we only have truncation: instead of a crash, there may be pid collisions when pid > 65535 (rarely critical for MTProxy).