Conversation
|
@nabe98 |
graphqomb/gflow_utils.py
Outdated
| #: Mapping between equivalent measurement bases. | ||
| #: | ||
| #: This map is used to replace a measurement basis by an equivalent one | ||
| #: to improve gflow search performance. | ||
| #: | ||
| #: Key: | ||
| #: ``(Plane, angle)`` where angle is in radians. | ||
| #: Value: | ||
| #: :class:`~graphqomb.common.PlannerMeasBasis`. |
There was a problem hiding this comment.
This seems very strange. I guess you can avoid this conversion somehow. If you really need to consider Pauli measurement, you have to use Pauli flow finding algorithm, though I don't think it necessary
There was a problem hiding this comment.
Why don't you use the Pauli flow finding algorithm rather than sticking to the complex transpilation? You should not modify the existing modules (e.g., common.py) just to implement ZX stuff.
| return graph, flow | ||
|
|
||
|
|
||
| def random_circ( |
There was a problem hiding this comment.
I suggest adding the include_phase_gadget parameter here.
|
@nabe98 Please explain why you implemented ZX-Calculus by yourself, not using the pyzx library |
2 participants
Before submitting, please check the following:
pytest)ruffmypyandpyrightmake htmlin./docs/- you may need to install dependency for sphinx docs, seedocs/requirements.txt.)Then, please fill in below:
Context (if applicable):
ZXGraphStateused for MBQC pattern simplificationDescription of the change:
ZXGraphStateoperations for local complement, pivot, Clifford removal, phase-gadget conversion, YZ-node merges, and afull_reduce pipeline, with helpers like_clifford_rules,_update_connections, andcomplete_graph_edges.full_reduceswiflowpackage to find the gflow. Wrapper function is implemented asgflow_wrapper.Related issue:
close #102