Merged
Conversation
added 2 commits
January 30, 2026 14:27
Collaborator
thierry-martinez
left a comment
There was a problem hiding this comment.
pyright fails because ANTLR parsers are not properly typed. I think it would be best to remove pyright from .github/workflows/typecheck.yml.
graphix_qasm_parser/parser.py
Outdated
|
|
||
| CZ = SWAP | ||
| else: | ||
| ANGLE_PI = 1.0 |
Collaborator
There was a problem hiding this comment.
I would prefer ANGLE_PI to be imported from graphix.fundamentals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example:
Previous to this PR, I was getting >12.0 for the angle when running the following code:
This update sets the value of
ANGLE_PIdepending on the version of Graphix in use.The problem was missed before because the test comparison used the same pi scaling for both terms being compared.
The PR also updates the README of the repo to accurately reflect the supported gates and their equivalent instructions.