feat: 크루 리더 위임 기능 추가 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
pparkjs
approved these changes
May 5, 2025
Contributor
pparkjs
left a comment
pparkjs
left a comment
There was a problem hiding this comment.
고생하셨습니다!! 코맨트 한 번 확인 부탈드릴게요!
Comment on lines
+144
to
+145
| CrewMember newLeader = crewMembers.delegateLeader(request.leaderId(), request.newLeaderId()); | ||
| return CrewLeaderDelegateResponse.of(newLeader); |
Contributor
There was a problem hiding this comment.
응답에 리더로 된 사용자만 내려주는데, 일반 참가자가 된 리더에 대한 정보는 필요없을까요?
Collaborator
|
@mandykr 님 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 PR 타입 선택
아래 타입 중 해당하는 하나를 선택해 주세요. 반드시 하나만 선택해 주세요.
feat: 새로운 기능 추가📝 변경 사항 요약
변경 사항을 간단히 요약해 주세요.
🛠 관련 이슈
Resolves: #36
추가 설명 (선택 사항)
변경 사항에 대한 추가 설명을 작성해 주세요.