Add manual reconnect button to File menu#739
Conversation
|
I'll need to test the implementation out before I can accept it, but a reconnect button sounds like a great idea to me. |
|
It might be more straightforward to go for a different approach, which is to create a method in client for Something that will need to be assessed if we were to stick with your proposed implementation is to look into is whether all the relevant code from client.py's retry code at https://github.com/Syncplay/syncplay/blob/master/syncplay/client.py#L873-L908 such as |
Resolves issues where users had to quit and restart Syncplay after connection times out.
|
Hey @Et0h I updated the commit based on your feedback. I agree with making the logic common so that if it ever changes, it'll affect both paths. Please let me know if you would like me to make any other changes. |
|
@xboxfanj I've done some testing of the feature and it seems to work fine from what I can tell and the code looks okay. What level of testing have you done on this feature so far? |
|
@Et0h I tested suspend/resume extensively. In the current state, that will never automatically reconnect. With this change, I can select the Reconnect button and it successfully reconnects. Network changes already seem to trigger the automatic reconnect in the current state. |
|
That's good to hear @xboxfanj - I must say, I hadn't thought of the scenario where someone suspends/resumes their machine and how Syncplay would behave in such a circumstance. |
Resolves issues where users had to quit and restart Syncplay after connection timeouts.