Error handling logic, more options, small optimizations#20
Open
tobek wants to merge 9 commits intoSwizec:masterfrom
Open
Error handling logic, more options, small optimizations#20tobek wants to merge 9 commits intoSwizec:masterfrom
tobek wants to merge 9 commits intoSwizec:masterfrom
Conversation
added 9 commits
July 2, 2014 19:52
Filed an issue in `request` module about this: request/request#954 For some URLs (e.g. http://cnb.cx/1vtyQyv), `request` throws this error on a HEAD request but not a GET request.
Looks like this chunk of code has been copied into the bitly function. It’s no longer reachable: if (map['bitly'].active) and the host is in the bitly map, the preceding for-loop would catch it. In addition, the bitly function handles the absence of options[‘bitly’] correctly anyway so no need to check for it.
Note that while using this option is slower than not using it, it is roughly the same (same # of requests) as *not* using the API and just using the generic method in the first place.
Instead of the original URL, because we may have successfully followed original URL to a new URL and only errored out on that one. We could also make this behavior optional.
The regex anyway breaks on unsual chars (like parentheses) in URLs Also some tiny cleanup/optimization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.