Open
Conversation
…ness. Works with smooth option.
pmadhikar
reviewed
May 14, 2019
| sys.path.append("/home/pranav/dev/celldiv/scripts") | ||
| #Default: violet stiff (healthy), orange soft (ill) | ||
|
|
||
| sys.path.append("/Users/Torsa_Legend/Desktop/ROBE TESI/Progr/scripts") |
Member
There was a problem hiding this comment.
Ah, we have to change this line. It shouldn't be required anymore since the compilation should add it to PYTHONPATH
pmadhikar
reviewed
May 14, 2019
| lamp.type = 'SUN' # in ['POINT', 'SUN', 'SPOT', 'HEMI', 'AREA'] | ||
| lamp.distance = 100 | ||
|
|
||
| #mio |
Member
There was a problem hiding this comment.
Please remove Italian comments.
pmadhikar
requested changes
May 14, 2019
| bpy.ops.object.delete() # delete mesh... | ||
|
|
||
| #roba mia | ||
| bpy.ops.object.select_pattern(pattern='scellObject') |
Member
There was a problem hiding this comment.
What if there are no soft cells?
| f = np.vstack(f) | ||
| faces = [] | ||
| for mi in range(int(len(f)/192)): | ||
| for row in firstfaces: |
Member
There was a problem hiding this comment.
The geometry definition should probably be moved into a function call...
Author
|
1) I didn't delete anything, just modified render. I can't tell which file
you see missing, and why.
2) I deleted three comments. Should I make another pull request just for
that?
3) If there are no soft cell, as far as I know, the selection is set to
Null and it doesn't delete anything. Should I add boolean guards?
4) What exactly do you want in a new function?
5) I am not sure that "sys.path.append("/Users/Torsa_Legend/Desktop/ROBE
TESI/Progr/scripts")" is not required. I invite you to generalize it using
PYTHONPATH.
Il giorno mar 14 mag 2019 alle ore 11:53 pmadhikar <notifications@github.com>
ha scritto:
… ***@***.**** requested changes on this pull request.
Why did you delete a file?
------------------------------
In scripts/render.py
<#5 (comment)>:
> @@ -183,7 +249,11 @@
bpy.ops.render.render(write_still=True) # render to file
bpy.ops.object.select_pattern(pattern='cellObject')
- bpy.ops.object.delete() # delete mesh...
+ bpy.ops.object.delete() # delete mesh...
+
+ #roba mia
+ bpy.ops.object.select_pattern(pattern='scellObject')
What if there are no soft cells?
------------------------------
In scripts/render.py
<#5 (comment)>:
> - for mi in range(int(len(f)/192)):
+ f0=[]
+ f1=[]
+ if sum(th.currTypes) > 0.1: #there is at least one cell with nonzero index
+ for cc in range(len(th.currTypes)):
+ if (th.currTypes[cc]):
+ f1.append(f[cc])
+ else:
+ f0.append(f[cc])
+
+
+ if len(f0) > 0:
+ f=f0
+ f = np.vstack(f)
+ faces = []
+ for mi in range(int(len(f)/192)):
for row in firstfaces:
The geometry definition should probably be moved into a function call...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=ALVGTTJTGA6GFI7AHT7QNS3PVKD2VA5CNFSM4HMYDGPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBYRHJ3A#pullrequestreview-237139180>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALVGTTNKDWISPBYZXMQRAD3PVKD2VANCNFSM4HMYDGPA>
.
|
Member
|
You don't need to make a new pull request. This one will update automatically whenever you push to the same branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified render.py to allow distinction of cells with different stiffness.
Works with smooth option.