DOCS-2933-fix-salt-explanation #311
Conversation
hhood-smartling
requested review from
Jackalx,
dnetrebenko-smartling and
maescomua
dnetrebenko-smartling
requested review from
dimitrystd,
sl-pkryshtop and
vfisyuk-smartling
| - **REUSE_EXISTING**: Returns an existing job if one matches the evaluated name template. If the matching job is | ||
| cancelled, deleted or closed, creates a new job with a unique name using the specified `salt` strategy. | ||
| closed, creates a new job with a unique name using the specified `salt` strategy. |
There was a problem hiding this comment.
According to the jobs facade service when mode is REUSE_EXISTING salt is applied when existing job's status is CANCELED, DELETED, or CLOSED, so the current documentation is correct.
https://github.com/Smartling/jobs-facade/blob/master/server/src/main/java/com/smartling/jobs/facade/service/JobsService.java#L113
https://github.com/Smartling/jobs-facade/blob/master/server/src/main/java/com/smartling/jobs/facade/jobs/JobApiV3Adaptor.java#L55
There was a problem hiding this comment.
Correct, it should use salt whenever the job is in the final state.
There was a problem hiding this comment.
Hi guys, I had tested this and in my sandbox salt was not applied if the job was canceled or deleted. See screenshot example in this ticket - https://smartling.atlassian.net/browse/DOCS-2933
This is also what we found when testing the Zapier app. See green box here - https://help.smartling.com/hc/en-us/articles/39746447095195-Smartling-s-Zapier-App#:~:text=If%20an%20existing%20daily%20or%20custom%20daily%20job%20is%20cancelled%2C%20deleted%20or%20closed%2C%20a%20new%20job%20is%20created%20(using%20the%20same%20job%20name%20as%20the%20previous%20daily%20job).%C2%A0If%20the%20previous%20job%20was%20closed%2C%20a%20sequence%20of%20alphanumeric%20characters%20is%20added%20as%20a%20suffix%20to%20the%20regular%20job%20name%2C%20in%20order%20to%20create%20a%20unique%20new%20job.
Is there something I'm missing?
| **When salt is applied**: | ||
| - With **REUSE_EXISTING**: Salt is appended when an existing job with the evaluated name is in a closed or completed | ||
| - With **REUSE_EXISTING**: Salt is appended when an existing job with the evaluated name is in a closed |
There was a problem hiding this comment.
According to the above:
| - With **REUSE_EXISTING**: Salt is appended when an existing job with the evaluated name is in a closed | |
| - With **REUSE_EXISTING**: Salt is appended when an existing job with the evaluated name is in a cancelled, deleted or closed |
https://smartling.atlassian.net/browse/DOCS-2933