Open
Conversation
added 4 commits
September 13, 2016 13:26
jtreuting
approved these changes
Sep 14, 2016
jtreuting
left a comment
jtreuting
left a comment
There was a problem hiding this comment.
Reviewed internally first. Looks good to me and we have tested it as well in our environments. It updates to a newer email library instead of using the low-level commands which is a more appropriate approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added the ability to use an email host that requires authentication to the sbacProcessXML.pl script. These changes were necessary to use Amazon's Simple Email Service (SES). Non-authenticated emails may still be sent by setting the useSmtpAuth flag to 0.