Switch to a "static standing" universe.#192
Draft
kitlith wants to merge 2 commits intoSlimeVR:mainfrom
Draft
Conversation
This is WIP and has yet to be tested. Would be completely unsurprised if applying the translation and rotation is currently incorrect. Just haven't gotten around to testing/tweaking it yet.
Member
Author
|
Finally got around to testing this today, looks like I stuffed up in two respects:
|
Still need to figure out how to apply the universe translation/rotation. In the driver, we just pass it as the 'WorldFromDriver' translation/rotation. Parsing the current universe works though, now, after merging the fixup PR to ovr_overlay.
Collaborator
|
Anything I can do on my end to move this forward? Would love if the overlay can be fixed |
Member
Author
We just need to figure out how to apply the universe offset here, which we didn't have to do in the driver because steamvr had a separate field for this. I'm pretty sure that's the only thing being done incorrectly right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is WIP and has yet to be tested. Would not be surprised if applying the translation and rotation is currently incorrect. Just haven't gotten around to testing/tweaking it yet.
Feel free to take this and run with it on your own, this should get the concept across.