Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // We want to do some floating point math at compile time | ||
| #![feature(const_fn_floating_point_arithmetic)] | ||
| // Asynchronous IMU sampling | ||
| #![feature(async_fn_in_trait)] |
Check warning
Code scanning / clippy
the feature `async_fn_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
| } | ||
|
|
||
| impl<I: I2c> Ism330Dhcx<I> { | ||
| pub fn new(mut i2c: I) -> Result<Self, <I as I2c>::Error> { |
Check warning
Code scanning / clippy
associated function `new` is never used
|
I've not seen this chip before. Do you have one you are using to test? |
|
If you don't even have the chip in hand, and didn't even run the code, and its a random IMU I've never anyone talk about in discord, I don't understand why you opened a PR. Marking as a draft until someone can test this on hardware. |
TheButlah
added
Status: Help Wanted
|
I'm going to assume that you acted in good faith and were not trying to spam PRs to prove a point. I'll be drafting up a clarification in the contributing.md making more clear what the bar is for merge. Hopefully that will help avoid these shenanigans in the future. |
|
This is definitely a petty shenanigan. However, this PR has been tested and verified against a drop-in compatible LSM6DS3TR |
2 participants
Probably applicable for other ST micro's IMUs #154