Skip to content

Conversation

@Skallwar
Copy link
Owner

@Skallwar Skallwar commented Jan 22, 2022

Fixes #68

Still some work to do but downloaded site are noticeably prettier now

@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #167 (f59c924) into master (931f1e5) will decrease coverage by 4.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   64.32%   60.08%   -4.24%     
==========================================
  Files          17       17              
  Lines         625      669      +44     
==========================================
  Hits          402      402              
- Misses        223      267      +44     
Impacted Files Coverage Δ
src/downloader.rs 68.46% <0.00%> (-2.56%) ⬇️
src/response.rs 100.00% <ø> (ø)
src/scraper.rs 18.66% <0.00%> (-4.04%) ⬇️

@Skallwar
Copy link
Owner Author

Also fixes #143 I guess, since fonts in CSS will be downloaded

@Skallwar
Copy link
Owner Author

Writing this makes me think that a good refactor is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support CSS scraping

2 participants