Skip to content

Conversation

@alexandr-simprints
Copy link
Contributor

JIRA ticket
Will be released in: 2025.4.1

Notable changes

Autofocus on tap is added to the OCR screen in the MFID workflow

Testing guidance

  • Open OCR screen
  • Move the credential physically close to the camera
  • Make tap on the background and on credential to see the focus being changed

Additional work checklist

  • Effect on other features and security has been considered

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CameraX focus controls to the external credential OCR scanning screen, enabling tap-to-focus (and initial autofocus) to improve OCR capture reliability in the MFID workflow.

Changes:

  • Extend ProvideCameraListenerUseCase to return the bound Camera instance via a new callback.
  • Wire CameraFocusManager into ExternalCredentialScanOcrFragment to set up tap-to-focus and autofocus on the preview.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/usecase/ProvideCameraListenerUseCase.kt Exposes the bound Camera instance to callers via onCameraReady.
feature/external-credential/src/main/java/com/simprints/feature/externalcredential/screens/scanocr/ExternalCredentialScanOcrFragment.kt Initializes focus controls on the camera preview using CameraFocusManager once the Camera is available.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant