[3.0] Issue 8134

[arlomedia]

Simplify the session lifetime calculations and always use the setting from the user interface.

From #8134

[jdarwood007]

I would prefer to see it like this, anyone concur?

@ini_set('session.gc_maxlifetime', max(min(Config::$modSettings['databaseSession_lifetime'], Config::$modSettings['databaseSession_lifetime']), 60));

Get the lowest of the server or SMF settings and ensure they have a sane value of at least 60.

[arlomedia]

This seems like a mistake: min(Config::$modSettings['databaseSession_lifetime'], Config::$modSettings['databaseSession_lifetime']). It sounds like you meant to write min(ini_get('session.gc_maxlifetime'), Config::$modSettings['databaseSession_lifetime']).

How about just max(Config::$modSettings['databaseSession_lifetime'], 60)? Then users could set it higher or lower than the server default setting.

[jdarwood007]

Ooops, I did typo that, but yes:

@ini_set('session.gc_maxlifetime', min(ini_get('session.gc_maxlifetime'), Config::$modSettings['databaseSession_lifetime']), 60));

[isaak654]

Aside from editing the title, if this pull request cannot be repurposed for branch 2.1, it may be preferable to submit a new one.