Conversation
8 tasks
There was a problem hiding this comment.
Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
Robust.Client/Graphics/Clyde/Clyde.Rendering.cs:420
- When disabling the scissor test, a call to CheckGlError() is omitted. For consistent error checking and debugging, consider invoking CheckGlError() after disabling the state.
else { GL.Disable(EnableCap.ScissorTest); }
Comment on lines
82
to
86
| var userId = Guid.Parse(reader.GetString(0)); | ||
| var userName = reader.GetString(1); | ||
| var token = reader.GetString(2); | ||
| serverUrl = reader.GetString(4); | ||
|
|
There was a problem hiding this comment.
Hardcoding the column index when retrieving the serverUrl makes the code fragile if the query order ever changes. Consider using named columns or defined constants to ensure the correct value is extracted even if the SQL query is updated.
Suggested change
| var userId = Guid.Parse(reader.GetString(0)); | |
| var userName = reader.GetString(1); | |
| var token = reader.GetString(2); | |
| serverUrl = reader.GetString(4); | |
| var userId = Guid.Parse(reader.GetString(reader.GetOrdinal("UserId"))); | |
| var userName = reader.GetString(reader.GetOrdinal("UserName")); | |
| var token = reader.GetString(reader.GetOrdinal("Token")); | |
| serverUrl = reader.GetString(reader.GetOrdinal("ServerUrl")); |
the last was engine version
…it fixed it EIGHT HOURS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.